FEAT: add LiteLLMChatTarget for multi-provider access via LiteLLM#2154
Merged
rlundeen2 merged 10 commits intoJul 14, 2026
Conversation
Contributor
|
I've been wanting to do this also; @RheagalFire this is a great start. I'll likely push to your branch to flush it out and support all the things (multi-modal, identifiers, underlying model, integration tests, capabilities detection, other gaps). So from your perspective I would consider this "merged" and I'll take it and try to get it in before the next release. TY for the help and nudge! |
…s, token usage) Extends the LiteLLM target for parity with OpenAIChatTarget and shares logic instead of reinventing it: - Extract shared Chat Completions helpers (chat_completions_message_builder, chat_completions_response_parser) used by both OpenAIChatTarget and LiteLLMChatTarget for request building and response parsing (text, image, audio, tool calls, content-filter handling). - Add multimodal support (image + audio input, audio output via audio_response_config) with capabilities derived from LiteLLM's model registry and a conservative text-only fallback. - Support the full OpenAI parameter set plus an extra_body_parameters passthrough; auth via sync/async token providers; identifiers that exclude the api_key; underlying_model capability lookup; and LiteLLM-owned retry (num_retries from PyRIT's global convention) to avoid double-retrying. - Add a provider-neutral TokenUsage value object (input/output/total/reasoning/cached + extra) and capture it for both targets; capture LiteLLM per-call cost. - Add litellm as an optional extra and include it in the 'all' extra. - Modernize type syntax (X | None), tidy docstrings per the style guide, and add unit + integration tests (image/audio on a gpt-5 deployment). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
… object Make TokenUsage a pure value object (fields + to_metadata/from_metadata) and move Chat Completions usage parsing into chat_completions_response_parser as token_usage_from_chat_completion, explicit to the one wire shape both chat targets actually send. - Drop the speculative Responses-API sniffing (no caller sends that shape); a Responses target should parse its own usage in its own module. - Tolerate dict-or-attribute usage payloads so a mapping no longer silently yields all-None counts. - Capture LiteLLM/Anthropic top-level cache fields (cache_read_input_tokens -> cached_tokens, cache_creation_input_tokens -> extra), preserving a zero cached count. - Move/expand parsing tests into test_chat_completions_helpers; test_token_usage now covers only metadata round-tripping. - Convert remaining Sphinx roles to plain double-backtick references. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ts to gpt-5.4 Revert the PLATFORM_OPENAI_CHAT_MODEL / PLATFORM_OPENAI_AUDIO_MODEL additions to .env_example and default the chat/vision integration fixtures to the deployed gpt-5.4 model instead of the generic "gpt-5". Also convert two stray Sphinx roles in the integration test docstrings to plain double-backtick references. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
romanlutz
reviewed
Jul 10, 2026
Rename the platform_* chat fixtures to azure_gpt5_* and point them at the Azure OpenAI GPT-5.4 deployment via LiteLLM's OpenAI-compatible openai/ prefix. The deployment is keyless, so fall back to a DefaultAzureCredential bearer-token provider when no key is set, which also exercises callable/Entra auth support. Audio tests stay on the platform OpenAI gpt-audio deployment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
Resolve conflicts from main's chat-target modernization and module relocations against this PR's shared chat-completion helper extraction: - Keep litellm optional: add a named `litellm` extra and include it in the `all` group (not a core dependency), avoiding the Rust-only litellm 1.92.0 build on Windows/macOS. Regenerate uv.lock accordingly. - Point shared helpers and the LiteLLM target at main's relocated APIs: data_serializer_factory/DataTypeSerializer now from pyrit.memory, convert_local_image_to_data_url_async from pyrit.memory.storage, _JsonResponseConfig from pyrit.prompt_target.common.json_response_config (json_config.json_schema), and async serializer methods (save_data_async / save_formatted_audio_async / read_data_base64_async). - ComponentIdentifier now imported from pyrit.models; get_known_capabilities used as the module-level function; _construct_message_from_response_async renamed for the async-suffix rule. - Drop the optional-install "pip install pyrit[litellm]" garble from the docstring and reference the clean extra. - Update affected unit tests to the relocated import paths and async mocks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
rlundeen2
approved these changes
Jul 13, 2026
rlundeen2
left a comment
Contributor
There was a problem hiding this comment.
I wrote a lot of it though so needs another review
Promote LiteLLM's core drop_params behavior to a first-class, documented
constructor argument (drop_unsupported_params, default True). It controls
whether provider-unsupported request params are silently dropped (the
cross-provider default) or raise for strict validation. A per-request
extra_body_parameters={"drop_params": ...} still overrides it.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
Remove max_completion_tokens and the mutual-exclusivity raise. LiteLLM normalizes max_tokens to the parameter each model/provider expects (e.g. max_completion_tokens for gpt-5/o-series), so a single knob works consistently across providers. Provider-specific token params remain reachable via extra_body_parameters. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
litellm 1.92.0 dropped the universal py3-none-any wheel in favor of manylinux-only wheels backed by a Rust/PyO3 extension. That breaks installs everywhere except Linux cp310-cp313: Windows/macOS have no wheels, and the sdist fails to build on Python 3.14 (PyO3 0.23.5 caps at 3.13). Pin to >=1.83.0,<1.92.0 (1.91.3 is the last pure-Python line) in both the litellm extra and the all group, and relock (1.92.0 -> 1.91.3). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
behnam-o
approved these changes
Jul 13, 2026
behnam-o
left a comment
Contributor
There was a problem hiding this comment.
overall looks good. Looks like quite a bit of deviation/overrides from the OpenAI Target patterns, but maybe this is even better and more generic (probably)...
- Move content-filter warning log from the shared builder to the LiteLLM call site (builders should not log; only the caller has that context). - Remove dead helper build_text_and_tool_pieces (logic lives inline in build_response_pieces_async). - Rename build_audio_pieces_async -> _build_audio_pieces_async (module-internal). - Type _construct_request_body json_config as _JsonResponseConfig instead of Any. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c01c3489-dd68-4db5-bad7-025b9e700379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
LiteLLMChatTarget, a new prompt target that uses the LiteLLM SDK (litellm.acompletion()) to reach 100+ providers (Anthropic, AWS Bedrock, Google Vertex, Cohere, etc.) directly — no separate proxy server required. LiteLLM speaks the OpenAI Chat Completions wire format, so the target shares its request-building and response-parsing logic withOpenAIChatTargetinstead of reinventing it.Key features
litellm.acompletion().input/outputmodalities and JSON support are read from LiteLLM's own model metadata (supports_vision,supports_audio_input/supports_audio_output,supports_response_schema,get_supported_openai_params) at construction, so multimodal (image/audio) input and audio output are enabled only when the resolved model actually supports them. Falls back to a text-only default when metadata is unavailable.api_key, a sync/async token provider callable (Entra-style), theLITELLM_API_KEYenv var, or LiteLLM's own provider-specific env var lookup.temperature,top_p,max_tokens,frequency_penalty,presence_penalty,seed,n,stop, plus arbitrary provider params viaextra_body_parameters.max_tokensknob — LiteLLM normalizesmax_tokensto whatever each model/provider expects (e.g.max_completion_tokensfor OpenAI reasoning/gpt-5 models), so callers set one value and it works cross-provider. Provider-specific token params remain reachable viaextra_body_parameters.drop_unsupported_paramsinit arg (defaultTrue) — first-class control over LiteLLM'sdrop_params, letting a single target send the full OpenAI parameter set across providers with differing support; setFalsefor strict validation. Overridable per request viaextra_body_parameters.usagepayloads are parsed into a new provider-neutralTokenUsagevalue object and persisted to message metadata.num_retries;litellm.exceptions.*are mapped to PyRIT'sRateLimitException/PyritExceptionhierarchy (rate-limit and transient errors become retryable, no bareExceptioncatches).Shared Chat Completions helpers (refactor)
To avoid duplicating logic between the OpenAI and LiteLLM targets, the Chat Completions request-building and response-parsing code is extracted into shared modules, and
OpenAIChatTargetis refactored to use them (net removal of ~250 lines there):pyrit/prompt_target/common/chat_completions_message_builder.py— builds Chat Completions request messages from PyRIT messages.pyrit/prompt_target/common/chat_completions_response_parser.py— parses Chat Completions responses (text/tool calls/audio, finish-reason validation, token usage).pyrit/models/token_usage.py— new provider-neutralTokenUsagevalue object (input/output vocabulary aligned with the Responses API/Anthropic/Gemini), with metadata (de)serialization. Provider→TokenUsageconversion lives in the parser/target that knows the wire format, not in the value object.Dependency
litellm>=1.83.0,<2.0.0added as an optional dependency: a namedlitellmextra and included in theallgroup (pip install pyrit[litellm]orpip install pyrit[all]). It is intentionally not a core dependency because current LiteLLM releases ship Linux-only wheels plus a Rust-based sdist, which would breakpip install pyriton Windows/macOS.import litellmis lazy, so users without the package are unaffected.Tests and Documentation
Unit tests (all passing):
tests/unit/prompt_target/target/test_litellm_chat_target.py— 54 tests (construction/env fallback, auth resolution, capability derivation, param/body construction,drop_unsupported_params,max_tokensnormalization + passthrough, audio, token usage, finish-reason and empty/malformed handling, exception translation, retries).tests/unit/prompt_target/target/test_chat_completions_helpers.py— 39 tests for the shared message builder / response parser.tests/unit/models/test_token_usage.py— 7 tests for theTokenUsagevalue object.tests/unit/prompt_target/target/test_openai_chat_target.py— updated for the shared-helper refactor.Integration tests:
tests/integration/targets/test_litellm_chat_target_integration.py— new, reusing existing Azure OpenAI deployments (routed through LiteLLM) so LiteLLM is exercised against real endpoints.tests/integration/targets/test_openai_chat_target_integration.py— updated (default integration model wired to an Azure GPT-5 deployment with Entra auth).Pre-commit (ruff format/check, ty type check, async-suffix and Sphinx-role hooks) passes clean.